Submission Details
Severity:
Consider using named constants instead of magic numbers
Summary
In order to improve readability is convenient to not leave magic numbers in the code
Vulnerability Details
Instances found:
File: Beedle.sol
_mint(msg.sender, 1_000_000_000 * 1e18);
File: Fees.sol
ISwapRouter.ExactInputSingleParams memory params = ISwapRouter.ExactInputSingleParams({[..], fee: 3000,
File: Lender.sol
-
if (_fee > 5000) -
if (_fee > 500) -
uint256 fees = (debt * borrowerFee) / 10000; -
fees = (lenderFee * interest) / 10000;
Tools Used
None
Recommendations
Create private constants for those magic numbers
Prize pool breakdown
Total prize
20,000 USDC
nSLOC
70628
USDC / LOC
18,000 USDC
2,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.