Submission Details
Severity:
Lack of collateral check can make loanRatio equals to 0.
Summary
During the calculation of loanRatio their is no check on the collateral , which makes the LoanRatio equals to 0, and makes the function reverts everytime..
Vulnerability Details
https://github.com/Cyfrin/2023-07-beedle/blob/main/src/Lender.sol#L618
uint256 loanRatio = (debt * 10 ** 18) / collateral;
if (loanRatio > pool.maxLoanRatio) revert RatioTooHigh();
Impact
function will get revert everytime on collateral = o .
Tools Used
Recommendations
Make a check for collateral , like under borrow function
https://github.com/Cyfrin/2023-07-beedle/blob/main/src/Lender.sol#L244
Prize pool breakdown
Total prize
20,000 USDC
nSLOC
70628 USDC / LOC
18,000 USDC
2,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.