Beedle - Oracle free perpetual lending

Summary

Vulnerability Details

Using the indexed keyword for value types (bool/int/address/string/bytes) saves gas costs, as seen in this example.

However, this is only the case for value types, whereas indexing reference types (array/struct) are more expensive than their unindexed version.

There are 5 instances of this issue:

• The following variables should be indexed in Lender.PoolBalanceUpdated(bytes32,uint256):

  • newBalance

• The following variables should be indexed in Lender.PoolInterestRateUpdated(bytes32,uint256):

  • newInterestRate

• The following variables should be indexed in Lender.PoolMaxLoanRatioUpdated(bytes32,uint256):

  • newMaxLoanRatio

• The following variables should be indexed in Lender.LoanBought(uint256):

  • loanId

• The following variables should be indexed in Lender.Refinanced(uint256):

  • loanId

Impact

Tools Used

Recommendations

Using the indexed keyword for values types bool/int/address/string/bytes in event