Submission Details
Severity:
[G-03] - Convert multiple `mappings` to single mapping using `struct`.
Details
In the Stacking contract we are using 3 differnt mappings to store supplyIndex, balances and claimable rewards. These all 3 mappings connected with user address. We can convert all these 3 mappings to single mapping using struct like this;
struct User {
uint256 supplyIndex;
uint256 balance;
uint256 claimable;
}
mapping(address => User) public users;
https://github.com/Cyfrin/2023-07-beedle/blob/main/src/Staking.sol#L19-L24
Just need to update places like this;
- balances[msg.sender] += _amount;
+ users[msg.sender].balance += _amount;
- claimable[msg.sender] = 0;
+ users[msg.sender].claimable = 0;
- supplyIndex[recipient] = index_;
+ users[recipient].supplyIndex = index_;
Prize pool breakdown
Total prize
20,000 USDC
nSLOC
70628 USDC / LOC
18,000 USDC
2,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.