Submission Details
Severity:
Unnecessery check in Staking contract
Summary
Staking contract has update function to update global index of earned rewards
Vulnerability Details
This function has the following code:
if (_balance > balance) {
uint256 _diff = _balance - balance;
if (_diff > 0) {
Where if first clause (_balance > balance) is true, the second one (_diff) will always be true.
Impact
Extra gas usage for unnecessary check
Tools Used
Observation
Recommendations
Delete second if statement
Prize pool breakdown
Total prize
20,000 USDC
nSLOC
70628 USDC / LOC
18,000 USDC
2,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.