Submission Details
Severity:
Extract common verification into a modifier
Summary
It's convenient to not duplicate code and extract whenever possible such code into a function.
Vulnerability Details
The following code is used multiple times in Lender.sol:
if (pools[poolId].lender != msg.sender) revert Unauthorized();
In such cases, it is recommended to create a modifier that will be verifying that the msg.sender is allowed to use functions addToPool, removeFromPool, updateMaxLoanRatio and updateInterestRate.
It will also save gas by having less code implemented.
Tools Used
None
Recommendations
modifier onlyLender() virtual {
if (pools[poolId].lender != msg.sender) revert Unauthorized();
_;
}
Prize pool breakdown
Total prize
20,000 USDC
nSLOC
70628
USDC / LOC
18,000 USDC
2,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.