Beedle - Oracle free perpetual lending

Summary

Using send or transfer function limits the gas to 2300 gas for the transaction. This is done to avoid reentrancy. But if the gas specification of ethereum change in future this function can become unusable. Using call with proper checks effects interactions pattern and reentrancy guard is the recommended approach.

Vulnerability Details

Use call instead of transfer function along with proper checks effects interactions pattern and reentrancyguards, as transfer function is restricted to 2300 and the ethereum gas specifications can change in future which can render the function useless.

Impact

If in future the gas specifications change then the current transfer function might become unusable as it restricts gas usage to 2300 gas.

Tools Used

Manual review

Recommendations

Use call instead of transfer or send function along with proper checks effects interactions pattern as transfer function is restricted to 2300 which can change in future.