Submission Details
Severity:
UNISWAP_FEE is hardcoded which will lead to significant losses compared to optimal routing
Summary
UNISWAP_FEE is hardcoded which will lead to significant losses compared to optimal routing
Vulnerability Details
In Fees.sol , UNISWAP_FEE is hardcoded, which reduce significantly the possibilities and will lead to non optimal routes.
the instance:
function sellProfits(address _profits) public {
require(_profits != WETH, "not allowed");
uint256 amount = IERC20(_profits).balanceOf(address(this));
ISwapRouter.ExactInputSingleParams memory params = ISwapRouter
.ExactInputSingleParams({
tokenIn: _profits,
tokenOut: WETH,
fee: 3000,
recipient: address(this),
deadline: block.timestamp,
amountIn: amount,
amountOutMinimum: 0,
sqrtPriceLimitX96: 0
});
amount = swapRouter.exactInputSingle(params);
IERC20(WETH).transfer(staking, IERC20(WETH).balanceOf(address(this)));
}
}
Impact
using the current implementation would create a significant loss of revenue.
Tools Used
manually
Recommendations
Basic mitigation would be to hardcode in advance the best Uniswap paths in a mapping.
Prize pool breakdown
Total prize
20,000 USDC
nSLOC
70628 USDC / LOC
18,000 USDC
2,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.