Beedle - Oracle free perpetual lending

Summary

Use storage instead of memory

Vulnerability Details

When fetching data from storage, using the memory keyword to assign it to a variable reads all fields of the struct/array and incurs a Gcoldsload (2100 gas) for each field.

This can be avoided by declaring the variable with the storage keyword and caching the necessary fields in stack variables.

The memory keyword should only be used if the entire struct/array is being returned or passed to a function that requires memory, or if it is being read from another memory array/struct.

Impact

Cost more gas.

Tools Used

Manual Review

Recommendations

• Consider using storage instead of memory