Submission Details
Severity:
Use scientific notation (e.g. `1e18`) rather than exponentiation (e.g. `10**18`)
Summary
Use scientific notation (e.g. 1e18) rather than exponentiation (e.g. 10**18)
Vulnerability Details
While the compiler knows to optimize away the exponentiation, it's still better coding practice to use idioms that do not require compiler optimization, if they exist.
File: src/Lender.sol
246: uint256 loanRatio = (debt * 10 ** 18) / collateral;
384: uint256 loanRatio = (totalDebt * 10 ** 18) / loan.collateral;
618: uint256 loanRatio = (debt * 10 ** 18) / collateral;
Link to code - https://github.com/Cyfrin/2023-07-beedle/tree/main/src/Lender.sol
Tools Used
Manual Code Review by SolSaver
Recommendations
Use scientific notation (e.g. 1e18) rather than exponentiation (e.g. 10**18)
Prize pool breakdown
Total prize
20,000 USDC
nSLOC
70628 USDC / LOC
18,000 USDC
2,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.