20,000 USDC
View results
Submission Details
Severity: gas
Valid

Functions not used internally could be marked external

Summary

Functions not used internally could be marked external

Vulnerability Details

File: src/Fees.sol
26: function sellProfits(address _profits) public {

Link to code - https://github.com/Cyfrin/2023-07-beedle/tree/main/src/Fees.sol

File: src/Lender.sol
232: function borrow(Borrow[] calldata borrows) public {
292: function repay(uint256[] calldata loanIds) public {
437: function startAuction(uint256[] calldata loanIds) public {
548: function seizeLoan(uint256[] calldata loanIds) public {
591: function refinance(Refinance[] calldata refinances) public {

Link to code - https://github.com/Cyfrin/2023-07-beedle/tree/main/src/Lender.sol

Tools Used

Manual Code Review by SolSaver

Recommendations

Functions not used internally could be marked external

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.