Beedle - Oracle free perpetual lending

Summary

Single step ownership transfer is being used instead of a 2-step one. This puts at risk the Beedle token, the Staking and Lender contracts.

Vulnerability Details

When a single step ownership transfer is used, theres the wide-known possibility of transferring the ownership to a wrong address by mistake.

Impact

In the case of Lender.sol, if ownership is transferred to an address that's not under the control of anyone of the governance team, this means not being able to collect accrued fees as well as losing access to setter functions that adjust system parameters.

Tools Used

Manual review

Recommendations

Use a 2-step ownership transfer procedure. This way if the new owner address has been inputted wrongly, it's has no detrimental effects on the ownership of the contracts.