Submission Details
Severity:
Precision loss in `_calculateInterest`
Summary
Risk of rounding down to zero in _calculateInterest
Vulnerability Details
If any of l.interestRate , l.debt , l.debt variables amount is too low, rounding down to zero can happen.
function _calculateInterest(
Loan memory l
) internal view returns (uint256 interest, uint256 fees) {
uint256 timeElapsed = block.timestamp - l.startTimestamp;
interest = (l.interestRate * l.debt * l.debt) / 10000 / 365 days;
fees = (lenderFee * interest) / 10000;
interest -= fees;
}
Impact
The interest amount for the lender would be zero.
Tools Used
Manual Review
Recommendations
Check if the product of the calculations in _calculateInterest is zero then revert.
Prize pool breakdown
Total prize
20,000 USDC
nSLOC
70628 USDC / LOC
18,000 USDC
2,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.