Submission Details
Severity:
[G-01] The owner can be declared inside the constructor
Summary
In the Ownable library, the msg.sender can be assigned directly to the owner variable, since in all the contracts that use this library, the msg.sender is passed as a parameter, a value that can be associated within the constructor.
Impact
Optimization
Tools Used
Manual code review
Recommendations
You can do this change :
src/utils/Ownable.sol
- constructor(address _owner) {
+ constructor() {
- owner = _owner;
+ owner = msg.sender;
- emit OwnershipTransferred(address(0), _owner);
+ emit OwnershipTransferred(address(0), owner);
}
And update the other declarations in the other contracts, since the msg.sender does not need to be passed by parameter
Prize pool breakdown
Total prize
20,000 USDC
nSLOC
70628 USDC / LOC
18,000 USDC
2,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.