Submission Details
Severity:
The `borrow` function operates with the logic that all ERC20 tokens are 18 decimals, this is incorrect
Summary
The borrow function operates on the logic that all ERC20 tokens are 18 decimals, whereas many tokens have different decimals,
Vulnerability Details
src/Lender.sol:
231 /// @param borrows a struct of all desired debt positions to be opened
232: function borrow(Borrow[] calldata borrows) public {
// Codes...
245: // make sure the user isn't borrowing too much
246: uint256 loanRatio = (debt * 10 ** 18) / collateral;
// Codes...
287: }
Impact
Tools Used
Manual Code Review
Recommendations
Check to decimal with loanRatio calculate
uint256 loanRatio = (debt * 10 ** (IERC20.decimals()) / collateral;
Prize pool breakdown
Total prize
20,000 USDC
nSLOC
70628 USDC / LOC
18,000 USDC
2,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.