Submission Details
Severity:
Protocol could fail to collect fees on multiple occasions
Summary
Any time the protocol collects fees, it does it via an unsafe ERC20 transfer call. There are some ERC20 tokens in existence that do not revert on transfer call failure which will lead to the protocol failing to collect fees when different actions are performed (almost all actions around pools and loans).
Vulnerability Details
See summary and relevant github links.
Impact
Protocol can fail to collect fees on multiple occasions.
Tools Used
Manual review
Recommendations
Use safeTransfer or require that the transfer call returns true as a result.
Prize pool breakdown
Total prize
20,000 USDC
nSLOC
70628 USDC / LOC
18,000 USDC
2,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.