The line uint256 public constant MAX_INTEREST_RATE = 100000;
uses a literal with too many digits, which can be difficult to read and review.
Literals with many digits are difficult to read and review, leading to errors and incorrect usage.The variable MAX_INTEREST_RATE
is assigned value 100000
, which can be difficult to read and review.
Using literals with many digits can lead to errors and incorrect usage of the variable. This can result in unexpected behavior and vulnerabilities in the code.
Manual Review
instead of using 100000
, you can use 1e5
to make the code more readable and less prone to errors. line uint256 public constant MAX_INTEREST_RATE = 100000;
can be rewritten as uint256 public constant MAX_INTEREST_RATE = 1e5;
.
The contest is live. Earn rewards by submitting a finding.
This is your time to appeal against judgements on your submissions.
Appeals are being carefully reviewed by our judges.