Submission Details
Severity:
Possible rounding issue
Summary
Vulnerability Details
Division by large numbers may result in the result being zero, due to solidity not supporting fractions.
file: Staking.sol
68: uint256 _ratio = _diff * 1e18 / totalSupply;
88: uint256 _share = _supplied * _delta / 1e18;
file: Lender.sol
561: uint256 govFee = (borrowerFee * loan.collateral) / 10000;
650: uint256 fee = (borrowerFee * (debt - debtToPay)) / 10000;
724: interest = (l.interestRate * l.debt * timeElapsed) / 10000 / 365 days;
Impact
When dividing by large numbers,the quotient may turn out to be zero.
Tools Used
Manual
Recommendations
Consider requiring a minimum amount for the numerator to ensure that it is always larger than the denominator
Prize pool breakdown
Total prize
20,000 USDC
nSLOC
70628
USDC / LOC
18,000 USDC
2,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.