Submission Details
Severity:
Lack of event in `Fees` contract
Summary
There are no event logs in the Fees contract. Implementing events, especially in critical functions like sellProfits, helps in maintaining transparency, tracking interactions, and facilitating debugging.
Impact
The lack of event logs makes it difficult for users, developers, and external systems to monitor contract activities and interactions.
Tools Used
Manual review
Recommendations
Define and emit events. Define appropriate events for significant contract activities and emit them at relevant points in the contract. For the sellProfits function, an event could be defined and emitted as follows:
event SellProfits(address indexed profitsToken, uint256 amountSwapped);
function sellProfits(address _profits) public {
// ... existing code ...
emit SellProfits(_profits, amount);
}
Prize pool breakdown
Total prize
20,000 USDC
nSLOC
70628 USDC / LOC
18,000 USDC
2,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.