Submission Details
Severity:
Protocols shouldn't set the deadline to block.timestamp
Summary
Protocols shouldn't set the deadline to block.timestamp as it can be manipulated by validators
Vulnerability Details
https://github.com/Cyfrin/2023-07-beedle/blob/658e046bda8b010a5b82d2d85e824f3823602d27/src/Fees.sol#L36
deadline is set to block.timestamp
Impact
a validator can hold the transaction and the block it is eventually put into will be block.timestamp, so this offers no protection
Tools Used
Manual Review
Recommendations
Protocols should allow users interacting with AMMs to set expiration deadlines
Prize pool breakdown
Total prize
20,000 USDC
nSLOC
70628 USDC / LOC
18,000 USDC
2,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.