Submission Details
Severity:
getPoolId can use abi.encodePacked
Summary
In Lender.sol, getPoolId encodes then keccak256 to generate an ID.
function getPoolId(
address lender,
address loanToken,
address collateralToken
) public pure returns (bytes32 poolId) {
poolId = keccak256(abi.encode(lender, loanToken, collateralToken));
}
Recommendations
This can be made more efficient by using encodePacked instead.
function getPoolId(
address lender,
address loanToken,
address collateralToken
) public pure returns (bytes32 poolId) {
poolId = keccak256(abi.encodePacked(lender, loanToken, collateralToken));
}
Impact
About 12 gas can be saved.
Tools Used
Foundry
Prize pool breakdown
Total prize
20,000 USDC
nSLOC
70628 USDC / LOC
18,000 USDC
2,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.