Potential reentrancy without following CEI pattern
Summary
Potential reentrancy without following CEI pattern or reentrancy attack protection
Vulnerability Details
https://github.com/Cyfrin/2023-07-beedle/blob/658e046bda8b010a5b82d2d85e824f3823602d27/src/Staking.sol#L38-L42
https://github.com/Cyfrin/2023-07-beedle/blob/658e046bda8b010a5b82d2d85e824f3823602d27/src/Staking.sol#L53-L58
effect happens after token transfer, which is easy to attack in this pattern
Impact
May lead to reentrancy attack if token has callback or simply write a malicious contract to reenter the function and drain the pool
Tools Used
Manual Review
Recommendations
follow check-effect-interaction pattern or use nonreentrant modifier from openzeppelin
Prize pool breakdown
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.