Beedle - Oracle free perpetual lending

Vulnerability Details

In both cases, the contract calls the transferFrom function to transfer tokens from the msg.sender (the borrower) to another address (address(this) or feeReceiver). However, the code does not check the return values of these transfer functions.

Impact

The impact of ignoring the return value of transferFrom functions is that the contract may not correctly account for token transfers, leading to consequences like the loss of tokens or incomplete transaction reversals on transfer failures, potentially resulting in financial loss

Tools Used

Slither

Recommendations or Mitigation

The mitigation for this issue is to handle the return values of the transferFrom functions using a require statement to check the success of the transfers and react appropriately if the transfer fails.