push a parameter into an array of tokens without checking if it already exists
Summary
push a parameter into an array of tokens without checking if it already exists
Vulnerability Details
https://github.com/Cyfrin/2023-07-beedle/blob/658e046bda8b010a5b82d2d85e824f3823602d27/src/Lender.sol#L276
push a new loan into array without checking
Impact
Repeating loans: If the existence of the loan in the loans array is not checked, it allows duplicate loan entries. This could lead to duplicate storage of loan information, impacting the accuracy and data consistency of the loans. Additionally, duplicate loan information may cause unexpected behavior or incorrect calculations.
Tools Used
Manual Review
Recommendations
Use a mapping to track existing loan objects. Only when confirming that the loan object does not exist, add it to the loans array
Prize pool breakdown
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.