Beedle - Oracle free perpetual lending

Summary

Unhandled return value of transferFrom and transfer in many instances could lead to fund loss.

Vulnerability Details

ERC20 implementations are not always consistent. Some implementations of transfer and transferFrom could return ‘false’ on failure instead of reverting. It is safer to wrap such calls into require() statements or use safe wrapper functions implementing return value/data checks to handle these failures

Impact

Some implementations of transfer and transferFrom could return ‘false’ on failure instead of reverting. It is safer to wrap such calls into require() statements or use safe wrapper functions implementing return value/data checks to handle these failures

Tools Used

Manual Review

Recommendations

It should wrap such calls into require() statements or use safe wrapper functions implementing return value/data checks to handle these failures