Submission Details
Severity:
State variables should be cached in stack variables rather than re-reading them from storage
Summary
State variables should be cached in stack variables rather than re-reading them from storage
Vulnerability Details
https://github.com/Cyfrin/2023-07-beedle/blob/main/src/Fees.sol#L26-L44
File: src/Fees.sol
function sellProfits(address _profits) public {
///@audit cache WETH
require(_profits != WETH, "not allowed");
uint256 amount = IERC20(_profits).balanceOf(address(this));
ISwapRouter.ExactInputSingleParams memory params = ISwapRouter
.ExactInputSingleParams({
tokenIn: _profits,
tokenOut: WETH,
fee: 3000,
recipient: address(this),
deadline: block.timestamp,
amountIn: amount,
amountOutMinimum: 0,
sqrtPriceLimitX96: 0
});
amount = swapRouter.exactInputSingle(params);
IERC20(WETH).transfer(staking, IERC20(WETH).balanceOf(address(this)));
}
diff --git a/Fees.org.sol b/Fees.sol
index 4254d82..9fd95bb 100644
--- a/Fees.org.sol
+++ b/Fees.sol
+ function sellProfits(address _profits) public {
+ address _weth = WETH;
+ require(_profits != _weth, "not allowed");
- function sellProfits(address _profits) public {
- require(_profits != WETH, "not allowed");
uint256 amount = IERC20(_profits).balanceOf(address(this));
ISwapRouter.ExactInputSingleParams memory params = ISwapRouter
.ExactInputSingleParams({
tokenIn: _profits,
+ tokenOut: _weth,
- tokenOut: WETH,
fee: 3000,
recipient: address(this),
deadline: block.timestamp,
});
amount = swapRouter.exactInputSingle(params);
+ IERC20(_weth).transfer(staking, IERC20(_weth).balanceOf(address(this)));
- IERC20(WETH).transfer(staking, IERC20(WETH).balanceOf(address(this)));
}
Prize pool breakdown
Total prize
20,000 USDC
nSLOC
70628 USDC / LOC
18,000 USDC
2,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.