20,000 USDC
View results
Submission Details
Severity: gas
Valid

Caching the pool variable for gas savings

Gas Issue Details

The following functions can be improved for gas savings by caching the state variable pools[poolId] in a local variable.

The Lender::setPool():

  • https://github.com/Cyfrin/2023-07-beedle/blob/658e046bda8b010a5b82d2d85e824f3823602d27/src/Lender.sol#L145

  • https://github.com/Cyfrin/2023-07-beedle/blob/658e046bda8b010a5b82d2d85e824f3823602d27/src/Lender.sol#L148

  • https://github.com/Cyfrin/2023-07-beedle/blob/658e046bda8b010a5b82d2d85e824f3823602d27/src/Lender.sol#L167

The Lender::addToPool():

  • https://github.com/Cyfrin/2023-07-beedle/blob/658e046bda8b010a5b82d2d85e824f3823602d27/src/Lender.sol#L183

  • https://github.com/Cyfrin/2023-07-beedle/blob/658e046bda8b010a5b82d2d85e824f3823602d27/src/Lender.sol#L185

  • https://github.com/Cyfrin/2023-07-beedle/blob/658e046bda8b010a5b82d2d85e824f3823602d27/src/Lender.sol#L187

The Lender::removeFromPool():

  • https://github.com/Cyfrin/2023-07-beedle/blob/658e046bda8b010a5b82d2d85e824f3823602d27/src/Lender.sol#L199

  • https://github.com/Cyfrin/2023-07-beedle/blob/658e046bda8b010a5b82d2d85e824f3823602d27/src/Lender.sol#L201

  • https://github.com/Cyfrin/2023-07-beedle/blob/658e046bda8b010a5b82d2d85e824f3823602d27/src/Lender.sol#L203

Gas Improvements

Cache the state variable pools[poolId] in a local variable and access the pool's parameters via the local (cached) variable instead.

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.