Submission Details
Severity:
[G-03] The update() function must be called before updateFor()
Summary
Since calling the updateFor function automatically calls the update function, it would be more gas-efficient to call update directly and then updateFor from the same function.
Impact
Gas Optimization and clearer code
Tools Used
Manual code review
Recommendations
Update the functions involved by first calling update then updateFor`. Like:
function deposit(uint _amount) external {
TKN.transferFrom(msg.sender, address(this), _amount);
+ update();
updateFor(msg.sender);
balances[msg.sender] += _amount;
}
and
function updateFor(address recipient) public {
- update();
uint256 _supplied = balances[recipient];
.....
....
...
..
.
Prize pool breakdown
Total prize
20,000 USDC
nSLOC
70628 USDC / LOC
18,000 USDC
2,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.