Submission Details
Severity:
## [G-28] Use assembly for math (add, sub, mul, div)
Summary
[G-28] Use assembly for math (add, sub, mul, div)
Use assembly for math instead of Solidity. You can check for overflow/underflow in assembly to ensure safety. If using Solidity versions < 0.8.0 and you are using Safemath, you can gain significant gas savings by using assembly to calculate values and checking for overflow/underflow.
file: /src/Lender.sol
723 uint256 timeElapsed = block.timestamp - l.startTimestamp;
724 interest = (l.interestRate * l.debt * timeElapsed) / 10000 / 365 days;
725 fees = (lenderFee * interest) / 10000;
https://github.com/Cyfrin/2023-07-beedle/blob/main/src/Lender.sol#L723-L725
file: /src/Lender.sol
618 uint256 loanRatio = (debt * 10 ** 18) / collateral;
https://github.com/Cyfrin/2023-07-beedle/blob/main/src/Lender.sol#L618
Prize pool breakdown
Total prize
20,000 USDC
nSLOC
70628 USDC / LOC
18,000 USDC
2,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.