Beedle - Oracle free perpetual lending

Summary

Missed deadline in ExactInputSingleParams

Vulnerability Details

The current implementation can lead to significant risks including unfavorable trade outcomes and potential financial loss. Without a user-specified deadline, transactions can remain in the mempool for an extended period, resulting in execution at a potentially disadvantageous time. Moreover, by setting the deadline to block.timestamp, a validator can hold the transaction without any time constraints, further exposing users to the risk of price fluctuations.

Advanced protocols like Automated Market Makers (AMMs) can allow users to specify a deadline parameter that enforces a time limit by which the transaction must be executed. Without a deadline parameter, the transaction may sit in the mempool and be executed at a much later time potentially resulting in a worse price for the user.

Impact

No expiration deadline may create a potential critical loss of funds

Tools Used

Manual review

Recommendations

Add deadline arguments to all functions that interact with AMMs, and pass it along to AMM calls.