Submission Details
Severity:
Duplicated `require`/`if` checks should be refactored to a modifier or function
Summary
Duplicated require/if checks should be refactored to a modifier or function
Vulnerability Details
Saves deployment costs
183 if (pools[poolId].lender != msg.sender) revert Unauthorized();
199 if (pools[poolId].lender != msg.sender) revert Unauthorized();
211 if (pools[poolId].lender != msg.sender) revert Unauthorized();
222 if (pools[poolId].lender != msg.sender) revert Unauthorized();
...
184 if (amount == 0) revert PoolConfig();
200 if (amount == 0) revert PoolConfig();
https://github.com/Cyfrin/2023-07-beedle/blob/main/src/Lender.sol
Impact
Gas savings
Tools Used
Manual review
Recommendations
Consider making a modifier instead of reaping some if statements
Prize pool breakdown
Total prize
20,000 USDC
nSLOC
70628 USDC / LOC
18,000 USDC
2,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.