Submission Details
Severity:
Missing check if loans and pools arrays are equal length
Summary
Function giveLoan() doesn’t check whether loanIds and poolIds arrays have the same length.
Vulnerability Details
There is no check if loanIds.length and poolIds.length are equal. To match the selling loan to the new pool.
Impact
If loanIds array is longer the function will revert when checking if pool.loanToken != loan.loanToken because all of the pool members will be default and pool.loanToken will be equal to zero address.
Tools Used
Manual
Recommendations
Add a check in the start of the function to confirm that loanIds and poolIds have equal length.
function giveLoan(uint256[] calldata loanIds, bytes32[] calldata poolIds) external {
if (loanIds.length != poolIds.length) revert MismatchedArrayLengths();
for (uint256 i = 0; i < loanIds.length; i++) {
...
}
Prize pool breakdown
Total prize
20,000 USDC
nSLOC
70628 USDC / LOC
18,000 USDC
2,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.