Beedle - Oracle free perpetual lending

Summary

Ownership is transferred in a single-step process.

Vulnerability Details

Impact

Transferring ownership address in one step is very risky because it is irrecoverable from any mistakes. If an incorrect address is used accidentally then it prevents the use of all the onlyOwner() functions forever. That will disable important functions such as setLenderFee and setBorrowerFee which are important for ensuring optimal performance and ability to adapt to changing market conditions.

Tools Used

Manual Analysis

Recommendations

Implement a two-step process where the owner nominates an account and the nominated account needs to call a newly created function for the transfer of ownership to fully succeed. This ensures the nominated EOA account is a valid and active account.