Submission Details
Severity:
Large numeric literals should use underscores for readability
Summary
Contributes to better visibility of the code
Vulnerability Details
59 uint256 public constant MAX_INTEREST_RATE = 100000;
265 uint256 fees = (debt * borrowerFee) / 10000;
561 uint256 govFee = (borrowerFee * loan.collateral) / 10000;
650 uint256 fee = (borrowerFee * (debt - debtToPay)) / 10000;
724 interest = (l.interestRate * l.debt * timeElapsed) / 10000 / 365 days;
725 fees = (lenderFee * interest) / 10000;
https://github.com/Cyfrin/2023-07-beedle/blob/main/src/Lender.sol#
Impact
Informational
Tools Used
Manual review
Recommendations
Large numeric literals should use underscores for readability
Prize pool breakdown
Total prize
20,000 USDC
nSLOC
70628
USDC / LOC
18,000 USDC
2,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.