Submission Details
Severity:
maxLoanRatio calculation differs from commentary
Summary
In the documentation, the ratio is figured as (loanToken / collateralToken) * 10**18, when in reality is (loanToken * 10**18) / collateralToken.
Vulnerability Details
File: src/utils/Structs.sol
15: /// @notice the max ratio of loanToken/collateralToken (multiplied by 10**18)
16: uint256 maxLoanRatio;
File: src/Lender.sol
246: uint256 loanRatio = (debt * 10 ** 18) / collateral;
Impact
No impact.
Tools Used
Manual review.
Recommendations
Adjust the comment to be sound with the code.
Prize pool breakdown
Total prize
20,000 USDC
nSLOC
70628 USDC / LOC
18,000 USDC
2,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.