Beedle - Oracle free perpetual lending

Summary

Uniswap V3 Router address is hardcoded into the contract.

Vulnerability Details

Impact

Because Uniswap V3 Router address is hardcoded and made constant Fees.sol will work only on Ethereum Mainnet and not on any other EVM-compatible chain. Also, there is a possibility that Uniswap changes the address of the Router contract in case of some vulnerability found inside of the router contract or for any other possible reason from their side that will force them to redeploy the contract.

Tools Used

Manual Analysis

Recommendations

Don't make ISwapRouter constant and create a function with onlyOwner() modifier from Ownable.sol that changes the Router address. Also, add the router address to the constructor, just like it is done with WETH and Staking contract address.