Submission Details
Severity:
Fees.sellProfits Uniswap V3 swap without slippage protection
Summary
Fees.sellProfits Uniswap V3 swap without slippage protection
Vulnerability Details
The function sellProfits(address _profits) in Fees contract executes UniswapV3 exactInputSingle swap without any slippage protection
function sellProfits(address _profits) public {
require(_profits != WETH, "not allowed");
uint256 amount = IERC20(_profits).balanceOf(address(this));
ISwapRouter.ExactInputSingleParams memory params = ISwapRouter
.ExactInputSingleParams({
tokenIn: _profits,
tokenOut: WETH,
fee: 3000,
recipient: address(this),
deadline: block.timestamp,
amountIn: amount,
amountOutMinimum: 0,
sqrtPriceLimitX96: 0
});
amount = swapRouter.exactInputSingle(params);
IERC20(WETH).transfer(staking, IERC20(WETH).balanceOf(address(this)));
}
Because amountOutMinimum has been hardcoded to 0, swaps are most likely to be sandwich attacked and protocol would lose funds.
Impact
Protocol is exposed to sandwich attacks, where the protocol would lose funds.
Tools Used
Manual Review
Recommendations
Add _amountOutMinimum parameter for the sellProfits function.
Prize pool breakdown
Total prize
20,000 USDC
nSLOC
70628
USDC / LOC
18,000 USDC
2,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.