20,000 USDC
View results
Submission Details
Severity: gas
Valid

Unnecessary inheritance complexity in BDL

The Beedle token inherits from ERC20, ERC20Permit, and ERC20Votes. Then the compiler requires mutual functions to be explicitly overridden, even though no logic is being changed. This is not necessary though, as ERC20Votes already inherits both ERC20 and ERC20Permit. The contract should only explicitly inherit ERC20Votes and the overriding functions without unique logic should be removed.

Repeated use of 1e18 as ratio factor should be a shared constant

The ratio factor (1e18) should be held in a constant to avoid replication of numbers across code.

Repeated use of 10000 as ratio factor should be a shared constant

The ratio factor (10000) should be held in a constant to avoid replication of numbers across code and improve code readability.

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.