Submission Details
Severity:
Missing approval before calling swap router
Summary
No approval before calling uniswap swap router
Vulnerability Details
ERC20 approval needs to be called before calling the uniswap swap router to allow uniswap receive the said tokens.
Impact
All fees are stuck in the fee contract
Tools Used
Recommendations
Add IERC20(_profits).approve(address(swapRouter), amount); here (https://github.com/Cyfrin/2023-07-beedle/blob/658e046bda8b010a5b82d2d85e824f3823602d27/src/Fees.sol#L29)
Prize pool breakdown
Total prize
20,000 USDC
nSLOC
70628 USDC / LOC
18,000 USDC
2,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.