Beedle - Oracle free perpetual lending

Summary

Hard coded fee tier doesn't not account for volatility of assets.

Vulnerability Details

There is currently no way to know the kind of assets that the fee contract will be receiving and their volatility. This means that depending on the asset, a different fee tier might be more reasonable. For example, if an asset has low volatility, there might be more liquidity in pools in a low fee tier and it would be cheaper to do trades. Also, new and better fee tiers could be introduced by uniswap but the fee contract would be unable to swap at the better rate because the fee tier is hardcoded.

Impact

Assets in the fee contract might not be sellable if there isn't enough liquidity in the fee tier or the protocol may be paying a higher fee than it would have otherwise paid if the tier was not hardcoded

Tools Used

Recommendations

Set the fee tier to be a function parameter