Submission Details
Severity:
Minimize Storage Reads/Writes
Summary
Avoid redundant storage reads and writes. If there is value in memory, it is no need to read from storage.
Vulnerability Details
In function borrow() and refinance(), we can use pool.poolBalance instead of pools[poolId].poolBalance to get the value.
Impact
cost more gas
Tools Used
Recommendations
For borrow function:
// update the pool balance
_updatePoolBalance(poolId, pool.poolBalance - debt);
pools[poolId].outstandingLoans = pool.poolBalance + debt;
For refinance function:
// now lets deduct our tokens from the new pool
_updatePoolBalance(poolId, pool.poolBalance - debt);
pools[poolId].outstandingLoans = pool.outstandingLoans + debt;
// update pool balance
pools[poolId].poolBalance = pool.poolBalance - debt;
Prize pool breakdown
Total prize
20,000 USDC
nSLOC
70628 USDC / LOC
18,000 USDC
2,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.