Submission Details
Severity:
Unchecked Return Values of ERC20 transfer() and transferFrom()
Summary
Return Values of ERC20 transfer() and transferFrom() are unchecked
Vulnerability Details
In contract Lender.sol the return val-
ues of an external transfer call is not checked. It should be noted that token
do not revert in case of failure and return false.
Impact
If one of those tokens is used, a deposit would not revert if the transfer fails and a user may loose his funds
Tools Used
Manual Review
Recommendations
It is recommended to use SafeERC20, or ensure that the transfer return
value is checked. The ERC20 standard recommends throwing exceptions in
functions transfer and transferFrom.
Prize pool breakdown
Total prize
20,000 USDC
nSLOC
70628 USDC / LOC
18,000 USDC
2,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.