Submission Details
Severity:
claim function doesn't follow CEI
Summary
Vulnerability Details
The claim function in the smart contract has an issue that does not follow the "check effects interactions" pattern.
Impact
While reentrancy attack is not possible I think it's better to follow CEI
Tools Used
Manual Review
Recommendations
Change claim function:
function claim() external {
claimable[msg.sender] = 0;
updateFor(msg.sender);
WETH.transfer(msg.sender, claimable[msg.sender]);
balance = WETH.balanceOf(address(this));
}
Prize pool breakdown
Total prize
20,000 USDC
nSLOC
70628 USDC / LOC
18,000 USDC
2,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.