Beedle - Oracle free perpetual lending

Summary

These functions allow the owner of the contract to set respective fees for the lender and the borrower. Although the functions are appropriate, there is a lack of event logging for changes in these parameters.

Vulnerability Details

The functions setLenderFee and setBorrowerFee are designed to modify the contract's state by adjusting the respective fees. However, they do not emit any event to indicate these changes. Without these events, it is difficult for external observers to track when and how the contract's state changes.

Impact

Adding an event will facilitate off-chain monitoring when changing system parameters.

Tools Used

1. VS Code

2. Manual Review

Recommendations

Consider to include event loggings within the setLenderFee and setBorrowerFee functions.