Submission Details
Severity:
`<x> += <y>` costs more gas than `<x> = <x> + <y>` for state variables
Summary
<x> += <y> costs more gas than <x> = <x> + <y> for state variables
Vulnerability Details
Using the addition/subtraction operator instead of plus-equals/minus-equals saves 113 gas
Impact
There are 14 instances of this issue:
File: 2023-07-beedle/src/Lender.sol
264: pools[poolId].outstandingLoans += debt;
315: pools[poolId].outstandingLoans -= loan.debt;
389: pools[poolId].outstandingLoans += totalDebt;
401: pools[oldPoolId].outstandingLoans -= loan.debt;
491: pools[poolId].outstandingLoans += totalDebt;
503: pools[oldPoolId].outstandingLoans -= loan.debt;
576: pools[poolId].outstandingLoans -= loan.debt;
634: pools[oldPoolId].outstandingLoans -= loan.debt;
638: pools[poolId].outstandingLoans += debt;
699: pools[poolId].poolBalance -= debt;
727: interest -= fees;
File: 2023-07-beedle/src/Staking.sol
41: balances[msg.sender] += _amount;
48: balances[msg.sender] -= _amount;
89: claimable[recipient] += _share;
Tools Used
Automated code review.
Recommendations
Consider using <x> = <x> + <y> or <x> = <x> - <y> instead.
Prize pool breakdown
Total prize
20,000 USDC
nSLOC
70628
USDC / LOC
18,000 USDC
2,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.