Beedle - Oracle free perpetual lending

Summary

Checking the value of transfer and transferFrom is a good practice because most of the tokens implement it differently.
we might assume that they revert on failure but they might not.

Vulnerability Details

transfer and transferFrom are expected to return a boolean. But in the code , we assumed that the call
to these functions will either succeed or revert.
But this might not be the case
Some tokens return a boolean for these functions on success( True ) and Failure ( False).

Total instances:24

Impact

-> Funds loss for contract and users
-> Incorrect Accounting inside the platform

Tools Used

Manual Review, Perpetual Trading Tutorial

Recommendations

Carefully check the return values of these functions and also check the balances of contract or users to ensure that tokens are transferred successfully!