Submission Details
Severity:
Permanent lock of funds in Fees contract due lack of token spending approval
Summary
The tokens sent to the Fees contract are potentially locked permanently as there is no token spending approval to the uniswap router before the swap.
Vulnerability Details
When swapping profits in Fees.sol the sellProfits function performs a UniswapV3 swap. However, the required _profits spending allowance for the ISwapRouter swapRouter contract is missing. This leads to a revert due to insufficient allowance.
Impact
Permanent lock of funds
Tools Used
Manual review
Recommendations
Add token spending allowance for the swapRouter before executing a swap.
Prize pool breakdown
Total prize
20,000 USDC
nSLOC
70628
USDC / LOC
18,000 USDC
2,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.