Lack of withdraw tokens function in Fees contract
Summary
There is no way to directly withdraw tokens from Fees contract, if the profit is in WETH there is no way to withdraw it only by making a fake swap with an other token, then in the end the WETH balance is being sent to the staking contract.
Vulnerability Details
When calling sellProfits function there is a check if the _profit input parameter is not equals WETH.
require(_profits != WETH, "not allowed");
Which effectively bricking WETH in the contract temporarily as there is no other way to withdraw WETH profits.
Impact
Lock of funds temporarily
Tools Used
Manual review
Recommendations
Add a withdrawToken function to the Fees contract.
Prize pool breakdown
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.