Vulnerability Details

The issue lies in Lender.sol where multiple functionalities do not emit an event. Emitting events is essential for notifying external entities such as users, chain explorers, or dApps about changes or conditions in the blockchain. Events, when emitted, store the arguments passed in transaction logs, making them accessible on the blockchain as long as the contract remains present.

Issue Location:

Lender.sol - Lines 84-87
Lender.sol - Lines 92-95
Lender.sol - Lines 100-102
Lender.sol - Lines 437-459

https://github.com/Cyfrin/2023-07-beedle/blob/main/src/Lender.sol#L84-L87

https://github.com/Cyfrin/2023-07-beedle/blob/main/src/Lender.sol#L92-L95

https://github.com/Cyfrin/2023-07-beedle/blob/main/src/Lender.sol#L100-L102

https://github.com/Cyfrin/2023-07-beedle/blob/main/src/Lender.sol#L437-459

Impact
The emission of events is crucial to inform the off-chain world about successful state transitions. For the system's credibility and confidence, it is essential that administration functionalities emit the corresponding events throughout the system's lifecycle.

Tools Used

Manual Review

Recommendations

To address this vulnerability, it is strongly advised to emit an event for these functions.