Submission Details
Severity:
Strict comparisons are more expensive than non-strict ones
Summary
The first two governance function from Lender.sol, setLenderFee and setBorrowerFee, check the input against hardcoded values
This check could be optimized by using non-strict comparison >= instead of strict comparison >.
Tools Used
Manual review
Recommendations
-if (_fee > 5000) revert FeeTooHigh();
+if (_fee >= 5001) revert FeeTooHigh();
-if (_fee > 500) revert FeeTooHigh()
+if (_fee >= 501) revert FeeTooHigh()
Prize pool breakdown
Total prize
20,000 USDC
nSLOC
70628
USDC / LOC
18,000 USDC
2,000 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.